New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(useScroll): support setting scroll position and toggling smooth scrolling #1996
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@curtgrimes maybe it would be better to implement this into useScroll as we might want to deprecate useWindowScroll in favor of useScroll |
@wheatjs Ok, should I can look at moving this functionality into |
Anthony and I briefly discussed it a couple days ago. Most functions are unlikely to be deprecated, we are only thinking about this one since it duplicates functionality |
Thanks. I'll migrate these changes over to useScroll. |
I have moved this functionality from useWindowScroll to useScroll. |
…scrolling Add ability to set scroll values and turn on or off smooth scrolling. fix #1978
Resolved merge conflict. |
Description
feat(useScroll): support setting scroll position and toggling smooth scrolling
Add ability to set scroll values and turn on or off smooth scrolling.
fix #1978
Demo
use-scroll-2.mov
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).