From 649e721ee10f677b6e4a7285fcee6179e1ae80df Mon Sep 17 00:00:00 2001 From: Adrien Foulon <6115458+Tofandel@users.noreply.github.com> Date: Mon, 18 Jul 2022 14:50:40 +0200 Subject: [PATCH 1/2] fix: missing key in for loop --- packages/vuetify/src/components/VCarousel/VCarousel.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/vuetify/src/components/VCarousel/VCarousel.ts b/packages/vuetify/src/components/VCarousel/VCarousel.ts index 1fc02986886..740cffbe0c6 100644 --- a/packages/vuetify/src/components/VCarousel/VCarousel.ts +++ b/packages/vuetify/src/components/VCarousel/VCarousel.ts @@ -139,6 +139,7 @@ export default VWindow.extend({ const children = [] for (let i = 0; i < length; i++) { + const val = this.getValue(this.items[i], i) const child = this.$createElement(VBtn, { staticClass: 'v-carousel__controls__item', attrs: { @@ -147,8 +148,9 @@ export default VWindow.extend({ props: { icon: true, small: true, - value: this.getValue(this.items[i], i), + value: val, }, + key: val, }, [ this.$createElement(VIcon, { props: { size: 18 }, From 8bbd6ab958c616d25fe98ada1afdb8e710bedd43 Mon Sep 17 00:00:00 2001 From: Adrien Foulon <6115458+Tofandel@users.noreply.github.com> Date: Mon, 18 Jul 2022 15:01:14 +0200 Subject: [PATCH 2/2] fix: ts error --- packages/vuetify/src/components/VCarousel/VCarousel.ts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/vuetify/src/components/VCarousel/VCarousel.ts b/packages/vuetify/src/components/VCarousel/VCarousel.ts index 740cffbe0c6..ea05e218094 100644 --- a/packages/vuetify/src/components/VCarousel/VCarousel.ts +++ b/packages/vuetify/src/components/VCarousel/VCarousel.ts @@ -139,7 +139,6 @@ export default VWindow.extend({ const children = [] for (let i = 0; i < length; i++) { - const val = this.getValue(this.items[i], i) const child = this.$createElement(VBtn, { staticClass: 'v-carousel__controls__item', attrs: { @@ -148,9 +147,9 @@ export default VWindow.extend({ props: { icon: true, small: true, - value: val, + value: this.getValue(this.items[i], i), }, - key: val, + key: i, }, [ this.$createElement(VIcon, { props: { size: 18 },