Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] v-edit-dialog with empty content is not editable #8465

Closed
satotake opened this issue Aug 11, 2019 · 4 comments · Fixed by #8466
Closed

[Bug Report] v-edit-dialog with empty content is not editable #8465

satotake opened this issue Aug 11, 2019 · 4 comments · Fixed by #8466
Assignees
@johnleider
Labels
C: VEditDialog VEditDialog T: bug Functionality that does not work as intended/expected T: regression Something that used to work but we broke
Milestone
v2.0.x

Comments

@satotake
Copy link
Contributor

Environment

Vuetify Version: 2.0.5
Vue Version: 2.6.10
Browsers: Chrome 76.0.3809.100
OS: Mac OS 10.14.6

Steps to reproduce

Expected Behavior

Users can start editing again for the empty cell when they click it

Actual Behavior

The edited cell is not clickable and editable

Reproduction Link

https://codepen.io/satotake/pen/ZgqvoE?&editable=true&editors=101

Other comments

Although the issue can be avoided if you add 'not-empty' rule,
it is often the case users make cells empty and this leads recoverable change for users.
@ghost ghost added the S: triage label Aug 11, 2019
@KaelWD
Copy link
Member

KaelWD commented Aug 11, 2019

Duplicate of #1282

@KaelWD KaelWD marked this as a duplicate of #1282 Aug 11, 2019
@satotake
Copy link
Contributor Author

Thanks @KaelWD
And sorry for duplication
I searched only open issues...
I have read #1282 and #1795 but I cannot judge whether this should be closed or not.

Though it seems at least to me a little bit strange as a default manner,
there are some easy workaround for it as you all pointed

@KaelWD
Copy link
Member

KaelWD commented Aug 11, 2019

Ah I forgot about #1795, this must be a regression then.

@KaelWD KaelWD added C: VEditDialog VEditDialog T: bug Functionality that does not work as intended/expected T: regression Something that used to work but we broke and removed S: triage labels Aug 11, 2019
satotake added a commit to satotake/vuetify that referenced this issue Aug 11, 2019
@satotake
fix(veditdialog): fix editability of VEditDialog with empty content
4bf3fe9 
wrap with div tag to keep activation region instead of single span tag

vuetifyjs#8465
@satotake satotake mentioned this issue Aug 11, 2019
Merged
7 tasks
@satotake
Copy link
Contributor Author

@KaelWD
I am trying to solve at #8466

johnleider pushed a commit that referenced this issue Aug 12, 2019
@satotake @johnleider
fix(VEditDialog): fix editability of VEditDialog (#8466)
8f5388f 
* fix(veditdialog): fix editability of VEditDialog with empty content

wrap with div tag to keep activation region instead of single span tag

fixes #8465

* chore(veditdialog): remove unnecessary style of VEditDialog

* chore(veditdialog): remove height: 100%, add display: inline-block
@johnleider johnleider self-assigned this Aug 12, 2019
@johnleider johnleider added this to the v2.0.x milestone Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnleider johnleider

Labels
C: VEditDialog VEditDialog T: bug Functionality that does not work as intended/expected T: regression Something that used to work but we broke
Projects
None yet
Milestone
v2.0.x
Development

Successfully merging a pull request may close this issue.

fix(VEditDialog): fix editability of VEditDialog satotake/vuetify
3 participants
@johnleider @satotake @KaelWD