Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VDataTable): remove unnecessary colspan in mobile view #8444

Merged
merged 1 commit into from
Aug 12, 2019

Conversation

jacekkarczmarczyk
Copy link
Member

Motivation and Context

colspan just seems unnecessary in mobile mode

How Has This Been Tested?

visually, updated snapshots

Markup:

<template>
  <v-container>
    <v-data-table
      :headers="headers"
      :items="desserts"
      :expanded.sync="expanded"
      show-select
      item-key="name"
      show-expand
      class="elevation-1"
    >
      <template v-slot:expanded-item="{ headers }">
        <td>
          <div style="width: 200px; height: 10px; background: red" />
        </td>
      </template>
    </v-data-table>
  </v-container>
</template>

<script>
  export default {
    data () {
      return {
        expanded: [],
        headers: [
          {
            text: 'Dessert (100g serving)',
            align: 'left',
            sortable: false,
            value: 'name',
          },
          { text: 'Calories', value: 'calories' },
          { text: 'Fat (g)', value: 'fat' },
        ],
        desserts: [
          {
            name: 'Frozen Yogurt',
            calories: 159,
            fat: 6.0,
          },
          {
            name: 'Ice cream sandwich',
            calories: 237,
            fat: 9.0,
          },
        ],
      }
    },
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)
  • I've added new examples to the kitchen (applies to new features and breaking changes in core library)

@jacekkarczmarczyk jacekkarczmarczyk added this to the v2.0.x milestone Aug 9, 2019
@jacekkarczmarczyk jacekkarczmarczyk self-assigned this Aug 9, 2019
@johnleider johnleider merged commit f56e2d8 into master Aug 12, 2019
@johnleider johnleider deleted the fix/v-data-table-remove-mobile-colspan branch August 12, 2019 19:46
@johnleider johnleider added C: VDataTable VDatatable T: bug Functionality that does not work as intended/expected labels Aug 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C: VDataTable VDatatable T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants