Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] v-avatar does not support SVG element as expected #8367

Closed
GregPeden opened this issue Aug 7, 2019 · 0 comments · Fixed by #8423
Closed

[Bug Report] v-avatar does not support SVG element as expected #8367

GregPeden opened this issue Aug 7, 2019 · 0 comments · Fixed by #8423
Assignees
@johnleider
Labels
C: VAvatar T: bug Functionality that does not work as intended/expected
Milestone
v2.0.x

Comments

@GregPeden
Copy link
Contributor

Environment

Vuetify Version: 2.0.5
Vue Version: 2.6.10
Browsers: Chrome 75.0.3770.142
OS: Windows 10

Steps to reproduce

Include svg element within v-avatar where more commonly img element is used

Expected Behavior

SVG element fills the intended v-avatar volume and is correctly occluded by the circular v-avatar geometry (or equivalent)

Actual Behavior

SVG loads in with 0 size. If forced to fill (ex. width=100%) then it will overflow beyond the circular container

Reproduction Link

https://codepen.io/gregpeden/pen/qeoOaP

Other comments

Supporting SVG is useful for supporting client-side rendered identicons like Dicebear Avatars
@ghost ghost added the S: triage label Aug 7, 2019
This was referenced Aug 9, 2019
Closed
Merged
@johnleider johnleider added C: VAvatar T: bug Functionality that does not work as intended/expected and removed S: triage labels Aug 12, 2019
@johnleider johnleider self-assigned this Aug 12, 2019
@johnleider johnleider added this to the v2.0.x milestone Aug 12, 2019
johnleider pushed a commit that referenced this issue Aug 12, 2019
@GregPeden @johnleider
fix(VAvatar): properly render when using a svg (#8423)
2cc5a4a 
fixes #8367

Right v-avatar only really works properly with <img> elements. There are cases where <svg> is preferred such as identicon graphics generated client-side. This change makes <svg> work as expected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnleider johnleider

Labels
C: VAvatar T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
v2.0.x
Development

Successfully merging a pull request may close this issue.

[Bug Report] Extend v-avatar functionality to work with SVG GregPeden/vuetify
2 participants
@GregPeden @johnleider