Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VBadge): enable unused variable (-top, -right) #8282

Merged
merged 1 commit into from
Aug 12, 2019
Merged

fix(VBadge): enable unused variable (-top, -right) #8282

merged 1 commit into from
Aug 12, 2019

Conversation

yuhigash
Copy link
Contributor

@yuhigash yuhigash commented Aug 3, 2019

Description

Enable unused sass variables.

Motivation and Context

I want to use the following sass variables.

$badge-top
$badge-right

How Has This Been Tested?

visually

Markup:

<template>
  <v-container>
    <v-badge>
      <template v-slot:badge>0</template>
      <v-icon>mail</v-icon>
    </v-badge>
  </v-container>
</template>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)
  • I've added new examples to the kitchen (applies to new features and breaking changes in core library)

@jacekkarczmarczyk
Copy link
Member

@yuhigash please add the playground example (see Markup section in other PRs for reference)

@yuhigash
Copy link
Contributor Author

yuhigash commented Aug 11, 2019

@jacekkarczmarczyk
Added the playground example.

test 1: no change (default)

remain the same

test 2: modify following sass(scss) variables

$badge-top: -($badge-height / 4);
$badge-right: -($badge-width / 4):

change as intented

@johnleider johnleider added this to the v2.0.x milestone Aug 12, 2019
@johnleider johnleider added C: VBadge VBadge T: bug Functionality that does not work as intended/expected labels Aug 12, 2019
@johnleider johnleider merged commit 811803b into vuetifyjs:master Aug 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C: VBadge VBadge T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants