Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] Google MD Icons are still being used in data tables groups #8255

Closed
mishamosher opened this issue Aug 1, 2019 · 0 comments · Fixed by #8285
Closed

[Bug Report] Google MD Icons are still being used in data tables groups #8255

mishamosher opened this issue Aug 1, 2019 · 0 comments · Fixed by #8285
Assignees
@nekosaur
Labels
C: VDataTable VDatatable S: has PR The issue has a pending Pull Request T: bug Functionality that does not work as intended/expected

Comments

@mishamosher
Copy link

Environment

Vuetify Version: 2.0.3
Vue Version: 2.6.10
Browsers: Mozilla Firefox, Safari, Microsoft Edge, Internet Explorer, Opera, Other
OS: Windows, Android, iOS, Mac OSX, Linux

Steps to reproduce

Please refer to the reproduction link.

Expected Behavior

Grouped tables should use the configured icon font only (MDI, FA, etc.)

Actual Behavior

Grouped tables still use Google MD Icons in some places.

Reproduction Link

https://codepen.io/anon/pen/oKejpb
@ghost ghost added the S: triage label Aug 1, 2019
@jacekkarczmarczyk jacekkarczmarczyk added the C: VDataTable VDatatable label Aug 1, 2019
@nekosaur nekosaur added T: bug Functionality that does not work as intended/expected and removed S: triage labels Aug 3, 2019
nekosaur added a commit that referenced this issue Aug 3, 2019
@nekosaur
fix(VDataTable): replace hardcoded icons for presets in grouped rows
382275f 
closes #8255
@nekosaur nekosaur mentioned this issue Aug 3, 2019
Merged
9 tasks
nekosaur added a commit that referenced this issue Aug 3, 2019
@nekosaur
fix(VDataTable): replace hardcoded icons for presets in grouped rows
bbafce6 
closes #8255
@nekosaur nekosaur added the S: has PR The issue has a pending Pull Request label Aug 3, 2019
johnleider pushed a commit that referenced this issue Aug 12, 2019
@nekosaur @johnleider
fix(VDataTable): replace hardcoded icons for presets in grouped rows (#…
014910a 
…8285)

closes #8255
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nekosaur nekosaur

Labels
C: VDataTable VDatatable S: has PR The issue has a pending Pull Request T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Bug] fix(VDataTable): replace hardcoded icons for presets in grouped rows vuetifyjs/vuetify
3 participants
@nekosaur @mishamosher @jacekkarczmarczyk