Skip to content

[Bug Report] Arrow keys don't work inside Vuetify dialog + contenteditable div #4715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
crankycyclops opened this issue Jul 25, 2018 · 1 comment
Assignees
Labels
T: bug Functionality that does not work as intended/expected
Milestone

Comments

@crankycyclops
Copy link

crankycyclops commented Jul 25, 2018

I ran into a strange issue that came about when I was trying to integrate QuillJS with a Vuetify project of mine, and it took me a long time to track this down. For some reason, the up and down arrows don't work inside contenteditables when they're placed inside Vuetify dialogs (I tested with fullscreen.) They work outside dialogs just fine.

I've created a Codepen to illustrate the issue: https://codepen.io/crankycyclops/pen/xJLbVY

If you try to scroll up and down, you'll see it doesn't work (only left and right work.)

Versions and Environment

Vuetify: 1.1.8
Vue: 2.5.16
Browsers: Chrome + Firefox

Steps to reproduce

  1. Load the codepen
  2. Click inside the contenteditable div
  3. Try to scroll using the up and down arrow keys

This bug only occurs when the contenteditable is inside a Vuetify dialog.

@crankycyclops
Copy link
Author

crankycyclops commented Jul 26, 2018

A few hours later, I've found a workaround. It seems this shouldn't be necessary, but I'm not sure if it's Vuetify's fault or not, so I'll leave it to you guys to decide if this is a bug that needs to be fixed. If I attach keyup.stop and keydown.stop events to the contenteditable div, then I'm able to suppress whatever listeners are preventing the up and down arrow keys from working the way they're supposed to.

@crankycyclops crankycyclops changed the title Arrow keys don't work inside Vuetify dialog + contenteditable div [Bug Report] Arrow keys don't work inside Vuetify dialog + contenteditable div Jul 26, 2018
@johnleider johnleider self-assigned this Jul 27, 2018
@johnleider johnleider added the T: bug Functionality that does not work as intended/expected label Jul 27, 2018
@johnleider johnleider added this to the v1.1.x milestone Jul 27, 2018
johnleider added a commit that referenced this issue Jul 27, 2018
was blocking arrow key propagation

BREAKING CHANGE: fixes #4715
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

No branches or pull requests

2 participants