Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report][3.6.5] text / background color issues in v-chip #19802

Closed
Ribeiro-Tiago opened this issue May 13, 2024 · 5 comments
Closed

[Bug Report][3.6.5] text / background color issues in v-chip #19802

Ribeiro-Tiago opened this issue May 13, 2024 · 5 comments
Labels
wontfix The issue is expected and will not be fixed

Comments

@Ribeiro-Tiago
Copy link

Environment

Vuetify Version: 3.6.5
Vue Version: 3.4.27
Browsers: Chrome 123.0.0.0
OS: Mac OS 10.15.7

Steps to reproduce

  • use v-chip component
  • give it a lighter background color
  • give it flat variant

Expected Behavior

to exist contrast between and background and text so the text is readable

Actual Behavior

almost no contrast, can't really see text

Reproduction Link

https://play.vuetifyjs.com/#...

Other comments

imo, since the text color changes based on the background color, there should be a check to ensure there's still a contrast between the 2 colours and fallback to a another color that would still be visible

@johnleider
Copy link
Member

The color generation system doesn't take into account transparency.

@Ribeiro-Tiago
Copy link
Author

@johnleider Does the label mean that you need more information from me or ..? :p

@johnleider
Copy link
Member

@KaelWD Do we have any intention to support HEXA in theme color generation?

@KaelWD
Copy link
Member

KaelWD commented May 13, 2024

No. Looks like we can pass opacity without breaking rgb(var()) by using r g b / a instead of r, g, b, but there's no way to tell what is behind a transparent element to determine an appropriate text color.

@johnleider johnleider added wontfix The issue is expected and will not be fixed and removed S: needs more information S: triage labels May 13, 2024
@johnleider
Copy link
Member

If you have any questions, please reach out to us in our Discord community.

@johnleider johnleider closed this as not planned Won't fix, can't repro, duplicate, stale May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix The issue is expected and will not be fixed
Projects
None yet
Development

No branches or pull requests

3 participants