Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report][3.5.16] Arabic Weekdays wrong in DatePicker #19676

Open
Daenara opened this issue Apr 23, 2024 · 4 comments
Open

[Bug Report][3.5.16] Arabic Weekdays wrong in DatePicker #19676

Daenara opened this issue Apr 23, 2024 · 4 comments
Labels
E: date T: bug Functionality that does not work as intended/expected T: documentation

Comments

@Daenara
Copy link

Daenara commented Apr 23, 2024

Environment

Vuetify Version: 3.5.16
Vue Version: 3.4.24
Browsers: Chrome 124.0.0.0
OS: Linux x86_64

Steps to reproduce

Find an Arabic speaker and have him look at the weekdays.

Expected Behavior

An Arabic speaker should recognize what weekday is which at glance, without having to puzzle.

Actual Behavior

My Arabic speaking colleague, that I asked to look over my translation, noticed that Monday is plain wrong, it seems to be the arabic letter n, which is not even in the word for Monday. Wednesday is abbreviated using the 2nd letter (most likely because it shares a first letter with Sunday) and it is not very intuitive.

Reproduction Link

https://play.vuetifyjs.com/#...

Other comments

I took a look at actual Arabic calendars with my colleague using google, and the
consensus seems to be to use the first two letters of the weekday, or just write the name in full.

@KaelWD
Copy link
Member

KaelWD commented Apr 23, 2024

This is just using new Intl.DateTimeFormat('ar', { weekday: 'narrow' }).format(new Date())

https://github.com/unicode-org/cldr/blob/af19649b0c44565a3ead370412ddacaf7b57b2a5/common/main/ar.xml#L1792-L1800

@Daenara
Copy link
Author

Daenara commented Apr 25, 2024

Even if it is just Intl doing it, I feel like vuetify should give me something to be able to fix it. It might even be some convention that is just never used in Arabic, but it seems to not be widely used.

I would really enjoy the ability to override this for specific languages, either by handing my own Intl.DateTimeFormat in, or by just having the option to use translation keys to override it.

Pretty sure Arabic is not the only language where what is defined isn't widely used.

@KaelWD KaelWD added T: bug Functionality that does not work as intended/expected E: date T: documentation and removed T: documentation labels Apr 26, 2024
@KaelWD
Copy link
Member

KaelWD commented Apr 26, 2024

createVuetify.date has a formats option but it isn't being used for getWeekdays, or you can pass a complete adapter. Maybe date-fns handles this differently?

If you think cldr is wrong here feel free to open an issue with unicode: https://github.com/unicode-org/cldr/blob/main/CONTRIBUTING.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E: date T: bug Functionality that does not work as intended/expected T: documentation
Projects
None yet
Development

No branches or pull requests

3 participants