Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report][3.5.16] V-defaults-Provider does not work on V-Dialog #19645

Open
tomfree opened this issue Apr 18, 2024 · 2 comments
Open

[Bug Report][3.5.16] V-defaults-Provider does not work on V-Dialog #19645

tomfree opened this issue Apr 18, 2024 · 2 comments
Labels
C: VDialog VDialog E: defaults Defaults composable S: triage

Comments

@tomfree
Copy link

tomfree commented Apr 18, 2024

Environment

Vuetify Version: 3.5.16
Vue Version: 3.4.23
Browsers: Chrome 123.0.0.0
OS: Windows 10

Steps to reproduce

Click on button "Click" and compare the VCards in the different colors

Expected Behavior

V-Card in V-Dialog should have rounded=="xl" applied as the V-dialog is within the v-defaults-provider

Actual Behavior

VCArd in V-Dialog uses rounded=='lg' and ignores the v-defaults-provider

Reproduction Link

https://play.vuetifyjs.com/#...

Other comments

See
1.) V-Card outside of v-defaults-provider to use rounded=='lg' which is correct
2.) V-Card inside of v-defaults-provider but outside of v-dialog to use rounded=='xl' which is correct
3.) V-Card inside of v-defaults-provider and inside of v-dialog to use rounded=='lg' which is incorrect as v-defaults-provider is not used here

@tomfree tomfree changed the title [Bug Report][3.5.16] V-Theme-Provider does not work on V-Dialog [Bug Report][3.5.16] V-defaults-Provider does not work on V-Dialog Apr 18, 2024
@johnleider
Copy link
Member

johnleider commented Apr 23, 2024

This is happening because we change the root here

<VDefaultsProvider root="VDialog">

Is there any thing we can do to hook into this @KaelWD?

@johnleider johnleider added C: VDialog VDialog E: defaults Defaults composable labels Apr 23, 2024
@KaelWD
Copy link
Member

KaelWD commented Apr 23, 2024

#15777

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VDialog VDialog E: defaults Defaults composable S: triage
Projects
None yet
Development

No branches or pull requests

3 participants