Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report][3.5.14] VTimePicker closes VMenu unexpected - unable to set time in 24hr format #19547

Open
KIDS-interactive opened this issue Apr 5, 2024 · 3 comments · May be fixed by #19569
Open

[Bug Report][3.5.14] VTimePicker closes VMenu unexpected - unable to set time in 24hr format #19547

KIDS-interactive opened this issue Apr 5, 2024 · 3 comments · May be fixed by #19569
Labels
S: triage

Comments

@KIDS-interactive
Copy link

Environment

Vuetify Version: 3.5.14
Last working version: 2.7.2
Vue Version: 3.4.21
Browsers: Chrome 123.0.0.0
OS: Windows 10

Steps to reproduce

Click on the input-field an click on a hour between 0-11

Expected Behavior

I expect the menu to stay open and the time to be selected

Actual Behavior

The menu closes and the hours are not selected

Reproduction Link

https://play.vuetifyjs.com/#...
@blalan05
Copy link
Member

blalan05 commented Apr 5, 2024

In the repo link, the menu is staying open and I can select hours and minutes. I'm on Windows 10, Chrome 123

@KIDS-interactive
Copy link
Author

Please have a look on this video. The error only occurs when clicking on hours 1-11.
Maybe you tested with touch-events enabled?

VPlay.-.Google.Chrome.2024-04-08.07-51-33.online-video-cutter.com.mp4

This occurs on multiple system.
Windows 10 & 11

  • Chrome 123.0.6312.105
  • Edge 123.0.2420.81
  • Firefox 121.0 and 124.0.2

Google Pixel 7 Pro Android 14
Here it works to select the hour, but the confirm-behavior is different to Desktop.
Desktop: Click on Minute and the model is updated
Mobile: Click outside to update the model

VPlay.-.Google.Chrome.2024-04-08.08-28-17.online-video-cutter.com.mp4

@KaelWD
Copy link
Member

KaelWD commented Apr 8, 2024

Weird how inconsistent it is, for me it closes if I click on anything but 12-23. If you're handling closing the menu yourself it should have :close-on-content-click="false", but the time picker controls should also be preventing click propagation anyway.

Side note you probably want min-width="0" not width="auto"

@blalan05 blalan05 linked a pull request Apr 9, 2024 that will close this issue
Fix(VTimePicker): Stop Propagation on events #19569
Open
@blalan05 blalan05 linked a pull request Apr 9, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S: triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix(VTimePicker): Stop Propagation on events vuetifyjs/vuetify
3 participants
@KaelWD @blalan05 @KIDS-interactive