Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report][2.6.7] VItemGroup does not correctly use valueComparator #15394

Closed
hrobertson opened this issue Jul 7, 2022 · 0 comments · Fixed by #15395
Closed

[Bug Report][2.6.7] VItemGroup does not correctly use valueComparator #15394

hrobertson opened this issue Jul 7, 2022 · 0 comments · Fixed by #15395
Assignees
Labels
C: VItemGroup VItemGroup T: bug Functionality that does not work as intended/expected
Milestone

Comments

@hrobertson
Copy link
Contributor

Environment

Vuetify Version: 2.6.7
Vue Version: 2.7.3
Browsers: Chrome 103.0.5060.53
OS: Linux x86_64

Steps to reproduce

  1. Use a V-Item-Group with object values or a custom valueComparator, or both.
  2. Observe that the active state of items is correct, but the value does not get updated correctly.

Expected Behavior

Model value is updated according to the valueComparator

Actual Behavior

Model value is updated according to exact equality.

Reproduction Link

https://codepen.io/hrobertson/pen/ExEPLGd

Other comments

#14328 only did half the job - Only the toggleMethod function was updated to use the valueComparator and this is only used for determining the active state, not for determining how the model value should be updated.

@KaelWD KaelWD added T: bug Functionality that does not work as intended/expected C: VItemGroup VItemGroup and removed S: triage labels Jul 7, 2022
@KaelWD KaelWD added this to the v2.6.x milestone Jul 7, 2022
@KaelWD KaelWD self-assigned this Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VItemGroup VItemGroup T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants