Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VCalendar): use theme background color for categories #14558

Merged
merged 1 commit into from Jan 19, 2022

Conversation

KareemDa
Copy link
Contributor

@KareemDa KareemDa commented Jan 1, 2022

Description

fixes #14433

Motivation and Context

How Has This Been Tested?

background color was set to white without getting sass varaibles og theme:calender

Markup:

<template>
  <v-app id="inspire">
      <v-calendar type="category"  />
  </v-app>
</template>

<script>
export default {
  mounted () {
    this.$vuetify.theme.dark = true;
  },
}
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@KaelWD KaelWD changed the title fix(VCalendar): Category type shows wrong background in dark mode fix(VCalendar): use theme background color for categories Jan 19, 2022
@KaelWD KaelWD merged commit 185408b into vuetifyjs:master Jan 19, 2022
@KaelWD KaelWD added this to the v2.6.x milestone Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][2.6.0] Calendar type=category display error in dark mode
2 participants