Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VInput): allow text selection in disabled inputs #14465

Merged
merged 4 commits into from Jun 15, 2022

Conversation

lentyaevpk
Copy link
Contributor

Description

Fixes #14238

How Has This Been Tested?

Visually

Markup:

// Paste your FULL Playground.vue here
<template>
  <v-app id="inspire">
    <v-text-field
      v-model="model"
      style="width: 200px"
      single-line
      outlined
    ></v-text-field>
    <v-text-field
      v-model="model"
      style="width: 200px"
      disabled
      single-line
      outlined
    ></v-text-field>
  </v-app>
</template>

<script>
  export default {
    data () {
      return {
        model: 'this is long text... this is long text... this is long text... this is long text... this is long text... ',
      }
    },
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@johnleider johnleider self-requested a review December 16, 2021 16:09
@johnleider johnleider added C: VInput VInput T: bug Functionality that does not work as intended/expected labels Dec 16, 2021
@johnleider
Copy link
Member

This is also an issue with autocomplete, combobox, and select, we should update those as well.

Playground: https://www.toptal.com/developers/hastebin/axosoliqas.xml

@lentyaevpk
Copy link
Contributor Author

@johnleider Updated autocomplete and combobox. Couldn't update select, because there is a div with text-overflow: ellipsis property

@KaelWD KaelWD changed the title fix(VInput): disabled text selection fix(VInput): allow text selection in disabled inputs Jun 15, 2022
@KaelWD KaelWD enabled auto-merge (squash) June 15, 2022 14:33
@KaelWD KaelWD disabled auto-merge June 15, 2022 14:33
@KaelWD KaelWD merged commit 760490d into vuetifyjs:master Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VInput VInput T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][2.5.8] v-text-field disable: can not select text to the end.
3 participants