Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VDivider): Vertical v-divider not displayed when inside div and… #12735

Conversation

NabeelAhmed314
Copy link
Contributor

… inline

fixes #8656

When using vertical v-divider inside div and with span the v-divider is not displayed. Added a display attribute to tackle this issue.

Description

Changed display of vertical v-divider from inline-flex to inline in order to make it displayed when used inside div and inlined.
resolves #8656

Motivation and Context

In order to start phase # 1 of Vuetify Titan all bugs with vdivider had to be resolved.
Resolves Following Issue.
#8656

How Has This Been Tested?

This has been tested visually.

Markup:

<template>
  <div id="parent">
    <span>Lorem ipsum dolor sit amet.</span>
    <v-divider
      class="mx-4"
      vertical
      color="primary"
    />
    <span>Lorem ipsum dolor sit amet.</span>
  </div>
</template>

<script>
  export default {
    data: () => ({
      //
    }),
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@MajesticPotatoe MajesticPotatoe added C: VDivider VDivider T: bug Functionality that does not work as intended/expected labels Dec 8, 2020
Copy link
Member

@MajesticPotatoe MajesticPotatoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Thank you for your contribution and interest in improving Vuetify! Make sure to join us in the Discord community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VDivider VDivider T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Vertical v-divider is not displayed when inside div
2 participants