Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VCarousel): stop event propagation for prev/next buttons #12678

Merged
merged 1 commit into from
Dec 8, 2020

Conversation

vibhash-singh
Copy link
Contributor

@vibhash-singh vibhash-singh commented Nov 26, 2020

Description

Stop click event propagation for prev/next buttons of VCarousel
Fixes #12676

Motivation and Context

Done to fix issue #12676

How Has This Been Tested?

visually

Markup:

<template>
  <v-container>
      <v-card @click="cardClick">
        <v-carousel>
          <v-carousel-item src="https://cdn.vuetifyjs.com/images/carousel/squirrel.jpg"></v-carousel-item>
          <v-carousel-item src="https://cdn.vuetifyjs.com/images/carousel/sky.jpg"></v-carousel-item>
        </v-carousel>
      </v-card>
  </v-container>
</template>

<script>
  export default {
    data: () => ({
    //
    }),
    methods: {
      cardClick: function () {
        console.log('cardClick')
      }
    }
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@MajesticPotatoe MajesticPotatoe added C: VCarousel VCarousel T: bug Functionality that does not work as intended/expected labels Dec 1, 2020
Copy link
Member

@MajesticPotatoe MajesticPotatoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Thank you for your contribution and interest in improving Vuetify! Make sure to join us in the Discord community.

@MajesticPotatoe MajesticPotatoe merged commit 07eb09e into vuetifyjs:master Dec 8, 2020
@vonec
Copy link

vonec commented Mar 2, 2021

is this live yet ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VCarousel VCarousel T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] v-carousel prev/next buttons should stopPropagation
3 participants