Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] Calendar type 4day. Change event actually spans 5 days instead of 4 #12666

Closed
ChristerGustavsson opened this issue Nov 24, 2020 · 0 comments · Fixed by #12687
Closed

[Bug Report] Calendar type 4day. Change event actually spans 5 days instead of 4 #12666

ChristerGustavsson opened this issue Nov 24, 2020 · 0 comments · Fixed by #12687
Labels
C: VCalendar VCalendar S: has PR The issue has a pending Pull Request T: bug Functionality that does not work as intended/expected

Comments

@ChristerGustavsson
Copy link

Environment

Vuetify Version: 2.3.18
Vue Version: 2.6.11
Browsers: Chrome 86.0.4240.198
OS: Mac OS 10.15.7

Steps to reproduce

Create a v-calendar with the props type="4day", start="2020-11-23", and end="2020-11-26".

The calendar presents everything as intended, starting with Monday the 23rd going to Thursday the 26th.

The initial onChange event that triggers gives the incorrect end date of Friday the 27th (2020-11-27)

Expected Behavior

The change event should be a range of 4 days

Actual Behavior

The change event adds 4 days to the start date making it 5 days in total

Reproduction Link

https://codepen.io/ChristerGustavsson/pen/WNGevwN

Other comments

I was using the change event to bind parameters used as query parameters to an API and noticed that they fetched more events than needed.
It seems like the other calendar types of day, week & month do not have this issue. I haven't tested with custom-weekly, custom-daily, or category.
yuwu9145 added a commit to yuwu9145/vuetify that referenced this issue Nov 28, 2020
@yuwu9145
Fix(VCalendar): resolve wrong relative day span for 4day
9a49922 
fixes vuetifyjs#12666
@yuwu9145 yuwu9145 mentioned this issue Nov 28, 2020
Merged
8 tasks
@MajesticPotatoe MajesticPotatoe added C: VCalendar VCalendar T: bug Functionality that does not work as intended/expected S: has PR The issue has a pending Pull Request labels Dec 1, 2020
MajesticPotatoe pushed a commit that referenced this issue Dec 8, 2020
@yuwu9145
fix(VCalendar): resolve wrong relative day span for 4day (#12687)
d9138f5 
fixes #12666
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: VCalendar VCalendar S: has PR The issue has a pending Pull Request T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(VCalendar): resolve wrong relative day span for 4day yuwu9145/vuetify
2 participants
@ChristerGustavsson @MajesticPotatoe