Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VTextField): add padding-top custom variable to details #12661

Merged
merged 1 commit into from
Dec 8, 2020
Merged

fix(VTextField): add padding-top custom variable to details #12661

merged 1 commit into from
Dec 8, 2020

Conversation

jeffpohlmeyer
Copy link
Contributor

@jeffpohlmeyer jeffpohlmeyer commented Nov 23, 2020

fixed #12660
fixes #12401

This is a small update to the bug I just recently submitted allowing for explicitly setting the padding-top of .v-text-field__details as error messages get cut off when using some fonts. One line was added to _variables.scss and one line to VTextField.sass.

Description

Resolves #12660 / #12401 by simply adding padding-top custom variable to VTextField

Motivation and Context

Error message in VTextField is cut off on top if using certain fonts like Nunito

How Has This Been Tested?

Has not been tested as this does not change anything because default padding-top on .v-text-field__details was already 0. Now it is just explicitly being set.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@MajesticPotatoe MajesticPotatoe added C: VTextField VTextField T: bug Functionality that does not work as intended/expected labels Nov 24, 2020
Copy link
Member

@MajesticPotatoe MajesticPotatoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Thank you for your contribution and interest in improving Vuetify! Make sure to join us in the Discord community.

@MajesticPotatoe MajesticPotatoe merged commit 47e190e into vuetifyjs:master Dec 8, 2020
@jeffpohlmeyer jeffpohlmeyer deleted the fix/12660-text-field-details-padding-top branch December 16, 2020 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VTextField VTextField T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] VTextField Error Message Cut Off [Bug Report] The top of letters and icons is cut off
2 participants