From 760490da75fc531fca9edcd4ef308f2698ba02aa Mon Sep 17 00:00:00 2001 From: Pavel Lentyaev <54902577+lentyaevpk@users.noreply.github.com> Date: Wed, 15 Jun 2022 17:33:47 +0300 Subject: [PATCH] fix(VInput): allow text selection in disabled inputs (#14465) fixes #14238 --- .../src/components/VAutocomplete/VAutocomplete.sass | 4 ---- packages/vuetify/src/components/VInput/VInput.sass | 7 ++----- packages/vuetify/src/components/VSelect/VSelect.sass | 4 +++- .../vuetify/src/styles/components/_selection-controls.sass | 3 +++ 4 files changed, 8 insertions(+), 10 deletions(-) diff --git a/packages/vuetify/src/components/VAutocomplete/VAutocomplete.sass b/packages/vuetify/src/components/VAutocomplete/VAutocomplete.sass index 814c7ac2705..c8bb9031415 100644 --- a/packages/vuetify/src/components/VAutocomplete/VAutocomplete.sass +++ b/packages/vuetify/src/components/VAutocomplete/VAutocomplete.sass @@ -34,10 +34,6 @@ .v-select__slot > input margin-top: $autocomplete-dense-enclosed-input-margin-top - &:not(.v-input--is-disabled).v-select.v-text-field - input - pointer-events: inherit - &__content.v-menu__content border-radius: 0 diff --git a/packages/vuetify/src/components/VInput/VInput.sass b/packages/vuetify/src/components/VInput/VInput.sass index 2ea8cef9a0a..99498d099f7 100644 --- a/packages/vuetify/src/components/VInput/VInput.sass +++ b/packages/vuetify/src/components/VInput/VInput.sass @@ -111,9 +111,6 @@ &--dense > .v-input__control > .v-input__slot margin-bottom: $input-dense-slot-margin-bottom - &--is-disabled:not(.v-input--is-readonly) - pointer-events: none - &--is-loading > .v-input__control > .v-input__slot &:before, &:after @@ -128,8 +125,8 @@ &--hide-spin-buttons input::-webkit-outer-spin-button, - input::-webkit-inner-spin-button + input::-webkit-inner-spin-button -webkit-appearance: none margin: 0 - input[type=number] + input[type=number] -moz-appearance: textfield diff --git a/packages/vuetify/src/components/VSelect/VSelect.sass b/packages/vuetify/src/components/VSelect/VSelect.sass index 3925b740f6a..400a6c0305c 100644 --- a/packages/vuetify/src/components/VSelect/VSelect.sass +++ b/packages/vuetify/src/components/VSelect/VSelect.sass @@ -63,7 +63,6 @@ input flex: 1 1 // Doesn't resize on IE11 with 3rd param min-width: 0 - pointer-events: none position: relative &:not(.v-text-field--single-line) input @@ -118,6 +117,9 @@ .v-select__selections flex-direction: row-reverse + &.v-input--is-disabled:not(.v-input--is-readonly):not(.v-autocomplete) + pointer-events: none + &__selections align-items: center display: flex diff --git a/packages/vuetify/src/styles/components/_selection-controls.sass b/packages/vuetify/src/styles/components/_selection-controls.sass index e066cdc5399..1d9d16a203d 100644 --- a/packages/vuetify/src/styles/components/_selection-controls.sass +++ b/packages/vuetify/src/styles/components/_selection-controls.sass @@ -109,6 +109,9 @@ .v-icon color: inherit + &.v-input--is-disabled:not(.v-input--is-readonly) + pointer-events: none + .v-input--selection-controls__input:hover .v-input--selection-controls__ripple:before background: currentColor