Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] make Vuetify-loader compatible with Vue 2.7 #240

Closed
DRoet opened this issue Jun 17, 2022 · 3 comments · Fixed by #247
Closed

[Feature Request] make Vuetify-loader compatible with Vue 2.7 #240

DRoet opened this issue Jun 17, 2022 · 3 comments · Fixed by #247
Assignees

Comments

@DRoet
Copy link
Contributor

DRoet commented Jun 17, 2022

Vuetify-loader directly depends on vue-template-compiler which won't be required when using 2.7 and vue-loader 15.10.

@vue/cli already made compatibility changes in their v5.0.6 release but I assume there is more work needed in the Vuetify-loader...

Thoughts @KaelWD ?

@KaelWD KaelWD self-assigned this Jun 17, 2022
@KaelWD KaelWD closed this as completed in d43460a Jun 21, 2022
@DRoet
Copy link
Contributor Author

DRoet commented Jun 21, 2022

@KaelWD I tried the 1.8.0 release but I think it requires more work, getting an error:

/app/node_modules/vuetify-loader/lib/loader.js:119
     const component = compiler.parseComponent(file)
                                ^
 TypeError: compiler.parseComponent is not a function
    at module.exports (/app/node_modules/vuetify-loader/lib/loader.js:119:32)
     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

looking at the source code from vue/compiler-sfc , It doesn't seem like it actually exports parseComponent

Edit: the parseComponent function definitely exists so that might be an oversight?

@DRoet
Copy link
Contributor Author

DRoet commented Jun 21, 2022

compiler.compile() is also not an available function, which would be the next problem.

@KaelWD
Copy link
Member

KaelWD commented Jun 21, 2022

Ugh, I thought it was just an alias like vue/server-renderer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants