Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add check before calling find on vue rule #170

Merged
merged 1 commit into from Mar 9, 2021

Conversation

domcorvasce
Copy link
Contributor

This loader expects to be loaded before vue-loader — at least when using Webpack 5.
You should receive the following error message when inverting the plugins' order:

[VuetifyLoaderPlugin Error] No matching rule for vue-loader found
Make sure there is at least one root-level rule that uses vue-loader and VuetifyLoaderPlugin is applied after VueLoaderPlugin.

Instead, it returns the following uninformative error message:

TypeError: rule.use.find is not a function

This PR updates getVueRules.js in order to return the proper error message.

@KaelWD KaelWD merged commit 22e2492 into vuetifyjs:master Mar 9, 2021
VladBarabash pushed a commit to Regme-Ltd/regme-vuetify-loader that referenced this pull request Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants