Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpack 5 support #136

Closed
hmnd opened this issue Jun 26, 2020 · 29 comments
Closed

webpack 5 support #136

hmnd opened this issue Jun 26, 2020 · 29 comments
Assignees

Comments

@hmnd
Copy link

hmnd commented Jun 26, 2020

In webpack/webpack#9138, the RuleSet class being used in lib/plugin.js has been refactored and no longer exists. This makes webpack 5 throw a MODULE_NOT_FOUND error when trying to build.

@KaelWD
Copy link
Member

KaelWD commented Jun 26, 2020

Related: vuejs/vue-loader#1613, JetBrains/svg-sprite-loader#403

@draeron
Copy link

draeron commented Oct 14, 2020

anyone knows a workaround for this ?

@JorisAerts
Copy link

Based on the changes on vue-loader, I also modified the plugin.js and created a plugin-webpack4 and plugin-webpack5 and it seems to work at first sight.

So, is there already someone in the process of fixing this? Is there an official fix pendig?

@KaelWD
Copy link
Member

KaelWD commented Oct 17, 2020

If you've made the changes already feel free to open a pull request.

This was referenced Nov 4, 2020
@bloodlit
Copy link

bloodlit commented Nov 6, 2020

Add webpack 5 support #160

@chamboug
Copy link

chamboug commented Nov 6, 2020

@bloodlit How is your PR different from mine (#158) created 2 days ago?

@Hecatron
Copy link

Hecatron commented Nov 6, 2020

Any news on this?, this would be useful since webpack 5 has inbuilt support for yarn2's pnp
and we have at least 2 pull requests in now for the same thing

@MaxMls
Copy link

MaxMls commented Nov 7, 2020

@grbd The last commit was 3 months ago, perhaps author is currently busy with the transition to version 3 and cannot accept pull requests
Perhaps a temporary fork would be a good solution.

@Hecatron
Copy link

Hecatron commented Nov 7, 2020

I think I'll need to go back to webpack4 anyways since there's some issues when using web-dev-server with webpack5 in combination with yarn v2 pnp

webpack/webpack-dev-server#2820

@alekbless
Copy link

I want to use this with the new Laravel Mix 6 and webpack 5 support is needed.

@bloodlit
Copy link

@alekbless take the lib folder from the branch add-webpack5-support

@glen-84
Copy link

glen-84 commented Dec 6, 2020

Related: vuejs/vue-loader#1613, JetBrains/svg-sprite-loader#403

Both of these PRs have been merged and released.

@KaelWD KaelWD self-assigned this Dec 6, 2020
@bkhatkov
Copy link

bkhatkov commented Dec 6, 2020

Hi guys. Is there any change to get this done? It seems much easier to switch to any other lib than to wait here. Vue added support of WP5 long time ago. Libs should follow as soon as possible. We invested quite a lot to develop our apps using vuetify and now we're just stuck...

@elricli
Copy link

elricli commented Dec 16, 2020

is there any progress?

@AGDholo
Copy link

AGDholo commented Dec 23, 2020

If I want to use the new es feature, I will have to update vue/cli to version 5, because webpack 4 has issues that prevent vue/cli4 from using these features, e.g. ??

But vuetify only supports webpack4, so it's hard to keep up with modern development.

@adiramardiani
Copy link

@AGDholo

But vuetify only supports webpack4, so it's hard to keep up with modern development.

In documentation vuetify not use only supports but version >=4 of Webpack
image

@AGDholo
Copy link

AGDholo commented Jan 5, 2021

In documentation vuetify not use only supports but version >=4 of Webpack

@adiramardiani

I installed vue cli 5 (webpack v5) and added vuetify, which prompts an error and I had to use the compatibility solution (installing webpack v4 again) to get it to work: https://github.com/vuejs/vue-cli/releases/tag/v5.0.0-alpha.0

@vstyler96
Copy link

I can't still solve my problem, I am still getting this:
image

@awill1988
Copy link

I have a PR #166 which is working for me, it mimics to the plugin-webpack4/5.js approach that exists in vue-loader. I think this gets us over the finish line right?

@vstyler96
Copy link

@awill1988 did you check this with laravel mix?

@awill1988
Copy link

I did not

@vstyler96
Copy link

@awill1988 are the custom variables working from webpack config? :o

@awill1988
Copy link

I'm not sure I'm about to publish an example with Vue2 Vuetify with module federation so that is my focus.. this seemed like the easiest lift

@KaelWD KaelWD closed this as completed in 4de3c94 Jan 18, 2021
@KaelWD
Copy link
Member

KaelWD commented Jan 18, 2021

v1.7.0 has been published as vuetify-loader@next. If you find any problems with webpack 5 please report them in a new issue.

@tux2nicolae
Copy link

Just updated to vuetify-loader@next and getting this

image

@mathe42
Copy link

mathe42 commented Jan 18, 2021

If you find any problems with webpack 5 please report them in a new issue.

Create a new issue for that! With a reproduction repro!

@stefanKuijers
Copy link

@tux2nicolae Could you link back to this issue if you create a new issue? Just so I can follow the progress as well. :)

@tux2nicolae
Copy link

@stefanKuijers Actually I didn't created a new issues as the problem may be fixed in 1.7.1 it works for me.

@bhanuunrivalled
Copy link

HI , Iam using "webpack": "^3.8.1"

  "vue": "^2.5.9",
    "vue-chart-js": "^1.4.1",
    "vue-chartkick": "^0.2.0",
    "vue-i18n": "^7.3.2",
    "vuetify": "^0.16.4"

is it possible for me to update to webpack 5? or webpack 4? which one is better?

VladBarabash pushed a commit to Regme-Ltd/regme-vuetify-loader that referenced this issue Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet