Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ESLint 9.x #93

Open
1Luc1 opened this issue Apr 8, 2024 · 6 comments · May be fixed by #98
Open

Support ESLint 9.x #93

1Luc1 opened this issue Apr 8, 2024 · 6 comments · May be fixed by #98
Labels
enhancement New feature or request

Comments

@1Luc1
Copy link

1Luc1 commented Apr 8, 2024

ESLint v9.0.0 is released !

It would be awesome to have official ESLint 9 support.
https://eslint.org/blog/2024/04/eslint-v9.0.0-released/

@cpontvieux-systra

This comment was marked as duplicate.

@kieuminhcanh
Copy link
Member

kieuminhcanh commented Apr 19, 2024

import vuetify from 'eslint-config-vuetify'

{
  ... 
  rules: {
      ...vuetify.rules,
      // Other rules
  }
  ...
}

@1Luc1
Copy link
Author

1Luc1 commented Apr 19, 2024

import vuetify from 'eslint-config-vuetify'

{
  ... 
  rules: {
      ...vuetify.rules,
      // Other rules
  }
  ...
}

// .eslintrc.js
https://eslint.org/docs/latest/use/configure/migration-guide

@kieuminhcanh meant to have dependency support for ESLint 9.x; still get ERESOLVE unable to resolve dependency tree for npm update:

npm ERR! While resolving: rehearsal-room-web@1.0.3
npm ERR! Found: eslint@9.0.0
npm ERR! node_modules/eslint
npm ERR!   dev eslint@"^9.0.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer eslint@"^8.0.0" from eslint-plugin-vuetify@2.4.0
npm ERR! node_modules/eslint-plugin-vuetify
npm ERR!   dev eslint-plugin-vuetify@"^2.4.0" from the root project

@corbinu
Copy link

corbinu commented Apr 20, 2024

@kieuminhcanh Can you please reopen? This request was for eslint-plugin-vuetify not eslint-config-vuetify.

@corbinu
Copy link

corbinu commented Apr 20, 2024

@1Luc1 I tried updating this repo to 9 but all the tests fail for not being flat file config. I will take a look to see if I can get them updated tomorrow and make a PR

@corbinu corbinu linked a pull request Apr 20, 2024 that will close this issue
@kieuminhcanh kieuminhcanh reopened this Apr 20, 2024
@SamPulmanCL
Copy link

Hi, are there any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants