refactor(markdown): remove codePlugin and add vPrePlugin (close #1550) #1556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9185430779Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Mister-Hope
requested changes
May 17, 2024
Co-authored-by: 张怀文 <mister-hope@outlook.com>
|
I think you can remove code Plugin entirely in this PR. |
Mister-Hope
changed the title
markdown.code, migrate to the ecosystem
Mister-Hope
requested changes
May 19, 2024
Mister-Hope
previously approved these changes
May 19, 2024
meteorlxy
reviewed
May 20, 2024
|
@meteorlxy Test is added, this should be ready. |
Mister-Hope
changed the title
meteorlxy
reviewed
May 22, 2024
| if (code !== false) { | ||
| md.use<CodePluginOptions>(codePlugin, code) | ||
| if (code) { | ||
| logger.warn( |
There was a problem hiding this comment.
Have we updated the docs? Or maybe we need to link to plugin docs?
There was a problem hiding this comment.
No, I will open a pr for this, note a route related pr is open a few days ago not not being merged.
meteorlxy
approved these changes
May 27, 2024
meteorlxy
added a commit
that referenced
this pull request
May 27, 2024
#1556) BREAKING CHANGE: `markdown.code` option is remove. Please use `@vuepress/plugin-shiki` and `@vuepress/plugin-prismjs` instead. -------------- Co-authored-by: 张怀文 <mister-hope@outlook.com> Co-authored-by: meteorlxy <meteor.lxy@foxmail.com>
meteorlxy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
close #123).What is the purpose of this pull request?
Description
See #1550 .
Related PRs：
codePluginfrom@vuepress/markdowntoplugin-shikiandplugin-prismjsecosystem#137