Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Router Warning with CJK filename(unencoded characters) #750

Closed
wafer-li opened this issue Jul 8, 2021 · 8 comments
Closed

[Bug] Router Warning with CJK filename(unencoded characters) #750

wafer-li opened this issue Jul 8, 2021 · 8 comments
Assignees
Labels
invalid This doesn't seem right

Comments

@wafer-li
Copy link

wafer-li commented Jul 8, 2021

Describe the bug

Router will complain the CJK filename.

Screenshots

image

Additional context

Add any other context about the problem here. Especially the issue occurs in certain OS, browser or configuation.

@wafer-li wafer-li added the bug Something isn't working label Jul 8, 2021
@wafer-li
Copy link
Author

wafer-li commented Jul 8, 2021

I think, it is the framework's duty to use a encodedURI().

Or is there some bug with encodedURI() fucntion?

@Mister-Hope
Copy link
Member

@Mister-Hope Mister-Hope added invalid This doesn't seem right and removed bug Something isn't working labels Jul 8, 2021
@wafer-li
Copy link
Author

wafer-li commented Jul 8, 2021

Sorry for my blind eye.

I checked that your branch is still ahead of the origin remote.

Therefore you could try to publish your own npm package under your namespace.

And use the fixed version to resolve this problem.

@Mister-Hope
Copy link
Member

Mister-Hope commented Jul 9, 2021

I checked that your branch is still ahead of the origin remote.

What do you mean here? What is the origin remote, my main branch aligning to vuepress@2? My code is nothing related to vuepress-plugin-blog

Therefore you could try to publish your own npm package under your namespace.
And use the fixed version to resolve this problem.

You are just triggering a warning, and it will have no effect in production mode.

The only problem is that you cannot directly navigate to a category or tag page, but that' a rare case. Also vuepress2 is on the way.

So I have no interest in forking a copy of vuepress-plugin-blog and maintain by my own. Remember that's an official plugin, which means the official has dropped vuepress v1 support. (Also vuepress has only less than 30 commits last year while 10 of them belong to docs)

@wafer-li
Copy link
Author

wafer-li commented Jul 9, 2021

I have tinkered this problem the whole night.

Even though I found out some solutions, neither of them is better than yours.

For now, we could only expect the vuepress2 release might be solving the problem.

The explanations to the misunderstanding containing my naive thoughts

What do you mean here? What is the origin remote, my main branch aligning to vuepress@2? My code is nothing related to vuepress-plugin-blog

I mean that you already make a PR of fix to vuepress-plugin-blog, that means you already have a fork of this plugin.

Then you could just publish a fixed version of vuepress-plugin-blog and use it as dependency in this theme.

@Mister-Hope
Copy link
Member

See vuepress/vuepress-plugin-blog#95 (comment)

If it's not been replyed in 3 days, I will publish a version.

@wafer-li
Copy link
Author

wafer-li commented Jul 9, 2021

And there is another approach, check vuepress-reco/vuepress-theme-reco@8fefc9f

It seems that it is still problematic. It is better not to modify the router stuff. Check https://github.com/vuepress-reco/vuepress-theme-reco/issues/364

@Mister-Hope
Copy link
Member

This problem must be fixed on plugin-blog side, becase /tag/使用指南/ is just what they are registing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants