Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Dynamic module hot reloading example #1744

Merged
merged 4 commits into from May 11, 2020
Merged

docs: add Dynamic module hot reloading example #1744

merged 4 commits into from May 11, 2020

Conversation

caugner
Copy link
Contributor

@caugner caugner commented May 5, 2020

I have looked for a way to load and hot reload Vuex modules systematically, rather than specifying them explictly.

Adapted from: kazupon/vue-i18n#865

Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This is pretty cool. Just made few comments on stylings. Please take a look 🙏

docs/guide/hot-reload.md Outdated Show resolved Hide resolved
docs/guide/hot-reload.md Outdated Show resolved Hide resolved
docs/guide/hot-reload.md Outdated Show resolved Hide resolved
@kiaking kiaking added the documentation Improvements or additions to documentation label May 8, 2020
docs/guide/hot-reload.md Outdated Show resolved Hide resolved
docs/guide/hot-reload.md Outdated Show resolved Hide resolved
Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 2 more comments 🙏

docs/guide/hot-reload.md Outdated Show resolved Hide resolved
docs/guide/hot-reload.md Outdated Show resolved Hide resolved
docs/guide/hot-reload.md Outdated Show resolved Hide resolved
docs/guide/hot-reload.md Outdated Show resolved Hide resolved
chore(docs): remove trailing commas
Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Wonderful 👍

@kiaking kiaking merged commit 91e2f7c into vuejs:dev May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants