Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: migrate tests to jest #1738

Merged
merged 4 commits into from May 8, 2020
Merged

build: migrate tests to jest #1738

merged 4 commits into from May 8, 2020

Conversation

kiaking
Copy link
Member

@kiaking kiaking commented Apr 30, 2020

Migrate test framework to Jest.

  • All unit tests are written in Jest.
  • Moved setup files out of unit filter and place it under test. This is for migrating E2E test to use Puppeteer instead of Nightwatch. In that time, we should be able to reuse this file since the test will all run with Jest.
  • Updated Babel to the latest.
  • Remove babel-polyfill due to deprecation. In the examples, we could add core-js pattern described here at the top.
  • Added yarn coverage to generate test coverage.

@kiaking kiaking added the build Related to the build system label Apr 30, 2020
@kiaking kiaking requested a review from ktsn April 30, 2020 12:01
@kiaking kiaking self-assigned this Apr 30, 2020
@kiaking kiaking force-pushed the jest branch 2 times, most recently from 4131642 to 384b50f Compare April 30, 2020 12:24
@Kocal
Copy link

Kocal commented Apr 30, 2020

This is for migrating E2E test to use prettier instead of Nightwatch

Do you mean Cypress instead of Prettier?

@kiaking
Copy link
Member Author

kiaking commented Apr 30, 2020

Do you mean Cypress instead of Prettier?

Sorry, I meant Puppeteer 🤦‍♂️ (fixed). I love Cypress! Though we're trying align with Vue 3.

.babelrc Outdated Show resolved Hide resolved
test/.eslintrc Outdated Show resolved Hide resolved
@kiaking
Copy link
Member Author

kiaking commented May 8, 2020

@ktsn Updated and also rebased to the latest branch 👍

Copy link
Member

@ktsn ktsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ktsn ktsn merged commit dfacba6 into dev May 8, 2020
@ktsn ktsn deleted the jest branch May 8, 2020 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to the build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants