chore: enhance release script #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktsn
reviewed
May 4, 2020
scripts/release.js
Outdated
| 'next' | ||
| ] | ||
|
|
||
| const inc = (i) => semver.inc(currentVersion, i, 'alpha') |
There was a problem hiding this comment.
Suggested change
| const inc = (i) => semver.inc(currentVersion, i, 'alpha') | |
| const inc = (i) => semver.inc(currentVersion, i, 'beta') |
Should be beta?
There was a problem hiding this comment.
I've removed this argument. Since it wasn't being used. We can use custom option in the selection when we need to release such a custom release 👍
|
@ktsn Updated 🤝 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the release script to better support the workflow, such as server validation and such.
Most of the code as taken from Vue 3 release script, but with minor update, which is it lets us select the release tag (
latestornext).