Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #9727 #9728

Merged
merged 2 commits into from Mar 18, 2019
Merged

fix #9727 #9728

merged 2 commits into from Mar 18, 2019

Conversation

VitorLuizC
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

This PR fix #9727.

@posva
Copy link
Member

posva commented Mar 17, 2019

Can you add a test using the createElement function (not explicitly setting the type VNodeData)

@VitorLuizC
Copy link
Contributor Author

VitorLuizC commented Mar 17, 2019

Done. Now, theres a component on vue-test.ts with render function that create elements with VNodeData's style as string | object and object[].

@yyx990803 yyx990803 merged commit 982d5a4 into vuejs:dev Mar 18, 2019
kiku-jw pushed a commit to kiku-jw/vue that referenced this pull request Jun 18, 2019
Lostlover pushed a commit to Lostlover/vue that referenced this pull request Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type of VNodeData style property should accept string values
3 participants