Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): cleanup timeouts for async components (fix #9648) #9649

Merged
merged 1 commit into from Mar 20, 2019
Merged

fix(core): cleanup timeouts for async components (fix #9648) #9649

merged 1 commit into from Mar 20, 2019

Conversation

ahus1
Copy link
Contributor

@ahus1 ahus1 commented Mar 7, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
component-async.spec.js now captures information about all created, triggered and cleared timeouts and verifies after the test that they have been cleared.
Should fix #9648

@ahus1
Copy link
Contributor Author

ahus1 commented Mar 17, 2019

Updated PR to include an additional test. The updated test spec now keeps track of all timeouts being set, triggered and cleared.

@yyx990803 yyx990803 merged commit 02d21c2 into vuejs:dev Mar 20, 2019
Maintenance automation moved this from To do to Done Mar 20, 2019
@ahus1 ahus1 deleted the async-timeout-cleanup branch March 20, 2019 08:25
kiku-jw pushed a commit to kiku-jw/vue that referenced this pull request Jun 18, 2019
Lostlover pushed a commit to Lostlover/vue that referenced this pull request Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Maintenance
  
Done
Development

Successfully merging this pull request may close these issues.

Timeouts for async components are not cleared, blocking node on ssr
2 participants