Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving nested async functional components is broken #9643

Closed
derz opened this issue Mar 7, 2019 · 3 comments · Fixed by #9673
Closed

Resolving nested async functional components is broken #9643

derz opened this issue Mar 7, 2019 · 3 comments · Fixed by #9673

Comments

@derz
Copy link

derz commented Mar 7, 2019

Version

2.6.8

Reproduction link

https://codesandbox.io/s/l07lp5vom

Steps to reproduce

As already quickly mentioned in here 03c13de nested functional components are broken since 2.6.8
1.) I have 2 functional components in the repro (Logo.vue / LogoWrapper.vue)
2.) The components are registered globally as async components (doesn't really make sense in this case.. but you should get the point :-)). Check components/_globals.js
3.) Using one of the component in the other (Logo inside LogoWrapper) breaks with the errormessage "Cannot read property '$on' of null" - this was working prior to 2.6.8

What is expected?

Components are renderer, no error message.

What is actually happening?

TypeError
Cannot read property '$on' of null

@posva posva added the bug label Mar 7, 2019
@yyx990803
Copy link
Member

yyx990803 commented Mar 8, 2019

I can't reproduce this locally. This may have something to do with functional template compilation? Can you manage to provide a repro without Nuxt or any build system involved?

@yyx990803 yyx990803 added need repro and removed bug labels Mar 8, 2019
@dejour
Copy link
Contributor

dejour commented Mar 11, 2019

After looked source code, I guess this can only happen with SSR, I will try make a test case for this.

@derz
Copy link
Author

derz commented Mar 11, 2019

yes, as mentioned by @dejour the bug only happens with SSR. Should I still add another repro without nuxt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants