Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): set end location for incomplete elements #9598

Merged
merged 1 commit into from Mar 1, 2019

Conversation

gzzhanghao
Copy link
Contributor

@gzzhanghao gzzhanghao commented Mar 1, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

End location for incomplete tags are missing, which makes error message looks weird:

  tag <incomplete-tag> has no matching end tag.

  2  |  <div>
  3  |    <div>
  4  |      <incomplete-tag>
     |      ^^^^^^^^^^^^^^^^
  5  |    </div>
     |  ^^^^^^^^
  6  |  </div>
     |  ^^^^^^

Expected:

  tag <incomplete-tag> has no matching end tag.

  2  |  <div>
  3  |    <div>
  4  |      <incomplete-tag>
     |      ^^^^^^^^^^^^^^^^
  5  |    </div>
  6  |  </div>

@yyx990803 yyx990803 merged commit cbad54a into vuejs:dev Mar 1, 2019
@gzzhanghao gzzhanghao deleted the incomplete-element branch March 4, 2019 03:30
kiku-jw pushed a commit to kiku-jw/vue that referenced this pull request Jun 18, 2019
Lostlover pushed a commit to Lostlover/vue that referenced this pull request Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants