fix #9571, rendering async components after initial context was destroyed #9572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maoberlehner
changed the title
maoberlehner
changed the title
maoberlehner
commented
Feb 26, 2019
| } | ||
|
|
||
| if (owner) owner.$on('hook:destroyed', () => removeOwner(owner)) | ||
|
|
There was a problem hiding this comment.
This stuff isn't mandatory. It doesn't break anything if destroyed owners are force updated. But it might be cleaner to remove them.
maoberlehner
commented
Feb 26, 2019
| // already pending | ||
| factory.owners.push(owner) | ||
| } else { | ||
| if (!isDef(factory.owners)) { |
There was a problem hiding this comment.
Not too happy with double checking for isDef(factory.owners) here and above but cleaner than moving this block above the block which returns the loadingComp I guess?!
kiku-jw
pushed a commit
to kiku-jw/vue
that referenced
this pull request
Jun 18, 2019
This was referenced Aug 29, 2019
This was referenced Sep 22, 2019
Lostlover
pushed a commit
to Lostlover/vue
that referenced
this pull request
Dec 10, 2019
This was referenced Jan 20, 2020
This was referenced Feb 24, 2020
This was referenced Mar 4, 2020
This was referenced Apr 15, 2020
This was referenced May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
I have not heavily tested this in a lot of circumstances. The async part of it almost broke my brain ^^ But tests are passing, so... ¯_(ツ)_/¯