Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lifecycle): beforeUpdated should not be called if component is de… #9171

Merged
merged 3 commits into from
Dec 11, 2018

Conversation

therealpecus
Copy link
Contributor

…stroyed, fix #8076

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
This properly fixes #8076 since PR #8381 did not cover beforeUpdate.


// #8076
it('should not be called after destroy', done => {
const beforeUpdated = jasmine.createSpy('beforeUpdated')
Copy link
Member

@posva posva Dec 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you meant beforeUpdate

Suggested change
const beforeUpdated = jasmine.createSpy('beforeUpdated')
const beforeUpdate = jasmine.createSpy('beforeUpdate')

posva and others added 2 commits December 10, 2018 12:00
fix typo on lifecycle event name (tx @posva)

Co-Authored-By: therealpecus <pecus@pecus.it>
@yyx990803 yyx990803 merged commit 87bad80 into vuejs:dev Dec 11, 2018
f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
aJean pushed a commit to aJean/vue that referenced this pull request Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

component calls update hook after it is destroyed
3 participants