Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this is a optimize for Comment RegExp #8619

Closed
minzhang2 opened this issue Aug 8, 2018 · 1 comment
Closed

this is a optimize for Comment RegExp #8619

minzhang2 opened this issue Aug 8, 2018 · 1 comment

Comments

@minzhang2
Copy link

minzhang2 commented Aug 8, 2018

Version

2.5.17

Reproduction link

https://github.com/vuejs/vue/blob/dev/src/compiler/parser/html-parser.js#L26

Steps to reproduce

I find the Comment RegExp has a '', but i find this '' is no use, so maybe can remove this. for ^<!--\

What is expected?

^<!--\

What is actually happening?

^<!--\

@sodatea
Copy link
Member

sodatea commented Aug 8, 2018

See #7298

@sodatea sodatea closed this as completed Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants