Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(functional): add scopedSlots to context in functional components #7941

Merged
merged 3 commits into from
Jan 9, 2019

Conversation

posva
Copy link
Member

@posva posva commented Apr 1, 2018

Related #5381

We discussed this being added to 2.6.
It is nothing new, as scopedSlots already exist on data. The only reasons to add it are convenience and consistency with slots (although slots is a function).
If you have arguments for or against this feature, please share them 🙂

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@posva
Copy link
Member Author

posva commented Apr 1, 2018

I may have forgotten some scenarios as well, to easy to add to be real 😆
I'm adding the typings

@yyx990803 yyx990803 added this to Todo in 2.6 Dec 28, 2018
@yyx990803 yyx990803 moved this from Todo to In progress in 2.6 Jan 9, 2019
@yyx990803 yyx990803 changed the base branch from dev to 2.6 January 9, 2019 21:13
@yyx990803 yyx990803 merged commit fb6aa06 into vuejs:2.6 Jan 9, 2019
2.6 automation moved this from In progress to Done Jan 9, 2019
yyx990803 added a commit that referenced this pull request Jan 9, 2019
f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
2.6
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants