Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@keydown.escape does not work in Edge #7880

Closed
salomvary opened this issue Mar 22, 2018 · 1 comment · Fixed by #7887
Closed

@keydown.escape does not work in Edge #7880

salomvary opened this issue Mar 22, 2018 · 1 comment · Fixed by #7887

Comments

@salomvary
Copy link

Version

2.5.16

Reproduction link

https://codepen.io/anon/pen/EEmBGm

Steps to reproduce

  • Open the linked reproduction link in Microsoft Edge
  • Open F12 developer tools console section
  • Click inside the input field on the Codepen output
  • Hit escape on the keyboard

What is expected?

@keydown.escape and @keydown.esc handlers should be triggered (should log 'esc' and 'escape').

What is actually happening?

@keydown.escape and @keydown.esc handlers are not triggered. Only the unfiltered @keydown handler and @keydown.27 are triggered.


Issue tested in Microsoft Edge 41.16299.15.0. Verified to be working as expected on latest Safari, Chrome and Firefox on macOS.

@posva
Copy link
Member

posva commented Mar 22, 2018

Cannot test on Edge right now but this may be related to the name Edge is giving to the name. If it's actually failing this is a good first issue, the fix should be at https://github.com/vuejs/vue/blob/dev/src/compiler/codegen/events.js#L21 (I can be wrong about the fix, but if I'm not it will help someone to get a contribution 🙂 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants