Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct the has implementation in the _renderProxy #7878

Merged
merged 1 commit into from Mar 22, 2018

Conversation

dcherman
Copy link
Contributor

It's feasible that someone might ask if something other than a string is
in the proxy such as a Symbol that lacks a charAt method. This aligns
the implementation with the getHandler.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

This issue was discovered when using vue-test-utils and the associated test helpers it provides. Ref: vuejs/vue-test-utils#452

It's feasible that someone might ask if something other than a string is
in the proxy such as a `Symbol` that lacks a `charAt` method.  This aligns
the implementation with the `getHandler`.
@dcherman
Copy link
Contributor Author

Not sure if there's a better way to test this logic other than how I wrote it unless we're willing to access the _renderProxy directly to just run an in test, but that's technically private implementation here. I didn't see any other tests using private impl, so I avoided doing so.

@yyx990803 yyx990803 merged commit 7b38739 into vuejs:dev Mar 22, 2018
EdBailey added a commit to EdBailey/vue that referenced this pull request Apr 13, 2018
f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
It's feasible that someone might ask if something other than a string is
in the proxy such as a `Symbol` that lacks a `charAt` method.  This aligns
the implementation with the `getHandler`.
aJean pushed a commit to aJean/vue that referenced this pull request Aug 19, 2020
It's feasible that someone might ask if something other than a string is
in the proxy such as a `Symbol` that lacks a `charAt` method.  This aligns
the implementation with the `getHandler`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants