Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add v-show style in ssr if style is binding to an array #7814

Merged
merged 1 commit into from Mar 13, 2018

Conversation

jinzhubaofu
Copy link
Contributor

web/server/directives/show just add style.display='none', no matter style is object or array; If
style is an array, it will lost additional property while tranformed into object by
shared/utils#toObject;

fix #7813

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

web/server/directives/show just add style.display='none', no matter style is object or array; If
style is an array, it will lost additional property while tranformed into object in
shared/utils#toObject;

fix vuejs#7813
@yyx990803 yyx990803 merged this pull request into vuejs:dev Mar 13, 2018
This was referenced Mar 14, 2018
f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
aJean pushed a commit to aJean/vue that referenced this pull request Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SSR] lost v-show if style is to binding to an array
2 participants