Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/7730 #7737

Merged
merged 4 commits into from Mar 8, 2018
Merged

Fix/7730 #7737

merged 4 commits into from Mar 8, 2018

Conversation

posva
Copy link
Member

@posva posva commented Mar 4, 2018

Forked from #7735

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@posva posva mentioned this pull request Mar 4, 2018
13 tasks
@Hanks10100
Copy link
Contributor

@yyx990803 I noticed that the weex test case is failed here and in many other PRs, but the modified codes have nothing with weex. That may because the version of weex-js-runtime is mismatched with these weex test cases.

Actually, the codes of weex in this repo are a little outdated, including the test cases. I can sync the codes and fix the ci, but I have to wait for these PRs to be merged and solve the conflicts with the latest code.

@yyx990803 yyx990803 merged commit db58493 into vuejs:dev Mar 8, 2018
@posva posva deleted the fix/7730 branch March 8, 2018 23:02
f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
aJean pushed a commit to aJean/vue that referenced this pull request Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants