Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): props getter shouldn't collect dependencies during initialization of data option (fix #7573) #7596

Merged
merged 6 commits into from Mar 9, 2018

Conversation

javoski
Copy link
Member

@javoski javoski commented Feb 2, 2018

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

Other information:
fix #7573.

@javoski javoski changed the title fix(core): props used in data option shouldn't be reactive (fix #7573) fix(core): props getter in data option shouldn't be reactive (fix #7573) Feb 2, 2018
@javoski javoski changed the title fix(core): props getter in data option shouldn't be reactive (fix #7573) fix(core): props getter shouldn't collect dependencies during initialization of data option (fix #7573) Feb 9, 2018
@yyx990803 yyx990803 merged commit 318f29f into vuejs:dev Mar 9, 2018
f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
…getter (vuejs#7596)

This fixes the parent being updated more than necessary due to collecting child props
as dependencies during its own update computation.

fix vuejs#7573
aJean pushed a commit to aJean/vue that referenced this pull request Aug 19, 2020
…getter (vuejs#7596)

This fixes the parent being updated more than necessary due to collecting child props
as dependencies during its own update computation.

fix vuejs#7573
@Hazlank Hazlank mentioned this pull request Aug 23, 2021
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pitfalls of Vue dependency detection may cause redundant dependencies
2 participants