Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue.config.performance can't work #7570

Closed
wants to merge 1 commit into from
Closed

Vue.config.performance can't work #7570

wants to merge 1 commit into from

Conversation

dear-lizhihua
Copy link

@dear-lizhihua dear-lizhihua commented Jan 31, 2018

https://jsfiddle.net/50wL7mdz/94913/

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@yyx990803
Copy link
Member

Thanks for the PR - note you can inspect the timeline by using Chrome devtool's performance recording and see the results in "User Timing". We are clearing the marks and measures because the API documentation seems to recommend that as good practice for saving memory. In practice, since this piece of code only gets called during development, it's probably fine to leave the measure entries. (mark entries are not that useful)

We will include it in 2.6.

@yyx990803 yyx990803 closed this Mar 8, 2018
yyx990803 added a commit that referenced this pull request Jan 15, 2019
f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants