Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no _ssr* in ssr functional tempalte #7443

Closed
wants to merge 1 commit into from
Closed

Conversation

clarkdo
Copy link
Contributor

@clarkdo clarkdo commented Jan 12, 2018

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Fix nuxt/nuxt#2565
When use Functional Components in ssr mode, the FunctionalRenderContext which is built in runtime is lack of _ssr* properties(_ssrNode, _ssrList, ...)

@yyx990803 yyx990803 closed this in 9b22d86 Mar 8, 2018
@yyx990803
Copy link
Member

Thanks for the PR! Since runtime copying for every context creation is non-optimal, I exposed the functional context and now it installs once on both Vue.prototype and the functional context prototype.

f2009 pushed a commit to f2009/vue that referenced this pull request Jan 25, 2019
aJean pushed a commit to aJean/vue that referenced this pull request Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does Nuxt fully support the latest Vue Functional Components?
2 participants