Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): event handler with modifiers swallowing arguments #10958

Merged
merged 1 commit into from Sep 21, 2020

Conversation

despreston
Copy link
Contributor

@despreston despreston commented Dec 27, 2019

Pass full parent argument list to the event handler when there are event
modifiers present.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

Fix #10867

@despreston
Copy link
Contributor Author

Hm. This is kind of strange b/c I can successfully run the todomvc app using my build w/o issue. I'm not very familiar with nightwatch; perhaps someone with a better eye can help me debug this one.

@posva
Copy link
Member

posva commented Dec 27, 2019

It's probably necessary to avoid the spread operator to support more browsers and use apply instead

@despreston despreston force-pushed the des/event-handlers-modifiers-args branch from 66c5a3c to 07cfa51 Compare December 27, 2019 14:55
…vuejs#10867)

Pass full parent argument list to the event handler when there are event
modifiers present.
@despreston despreston force-pushed the des/event-handlers-modifiers-args branch from 07cfa51 to 3d31982 Compare December 27, 2019 15:02
@despreston
Copy link
Contributor Author

@posva Thanks again!

@despreston
Copy link
Contributor Author

@posva Do you know if there's a plan to push this into production soon? I'm actually being bit by this in a project now. The workaround works but obviously I'd prefer the solution I helped fix 😝.

@posva posva changed the title fix(compiler): event handler with modifiers swallowing arguments (fix #10867) fix(compiler): event handler with modifiers swallowing arguments Sep 21, 2020
@posva posva force-pushed the des/event-handlers-modifiers-args branch from aff02d7 to 3d31982 Compare September 21, 2020 09:36
@posva posva merged commit 8620706 into vuejs:dev Sep 21, 2020
@despreston despreston deleted the des/event-handlers-modifiers-args branch February 17, 2021 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple arguments in custom event with a modifier are not passed to handler
2 participants