Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): remove trailing comma in function signature #10845

Merged
merged 1 commit into from Sep 21, 2020
Merged

Conversation

posva
Copy link
Member

@posva posva commented Nov 19, 2019

Fix #10843

Since it's not supported on many browsers, we should just remove it

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@jacekkarczmarczyk
Copy link

Maybe stupid queston but shouldn't you use some linter to detect this kind of problems?

@posva
Copy link
Member Author

posva commented Nov 20, 2019

It's not a stupid question. The rule is already there but it wasn't supported on eslint until v6 apparently

@phanan
Copy link
Member

phanan commented Nov 20, 2019

This is the real stupid question: The bundler should already have handled this, right?

@posva
Copy link
Member Author

posva commented Nov 20, 2019 via email

@posva posva merged commit 579e1ff into dev Sep 21, 2020
@posva posva deleted the posva-patch-1 branch September 21, 2020 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected comma in the function declaration
6 participants