Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(props): correctly warn when a provided prop is Symbol #10529

Merged
merged 2 commits into from Sep 21, 2020

Conversation

posva
Copy link
Member

@posva posva commented Sep 17, 2019

Fixes #10519

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@issasami
Copy link

Hello everyone, when can I use this fix? thx

@AMBudnik
Copy link

👍 waiting for merge

@dlkulp
Copy link

dlkulp commented Jan 22, 2020

+1 for getting this merged since it's been a while....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prop validator fails to generate validation error message when using Symbols
6 participants