Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(warns): modify maybeComponent function in parser #10167

Merged
merged 1 commit into from Apr 7, 2021

Conversation

zrh122
Copy link
Contributor

@zrh122 zrh122 commented Jun 19, 2019

Add condition to see whether the element may be an component.
fixes #10152

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@Boudewijn26
Copy link

Is there any indication on the continuation of this PR? I've run into the same issue and would love to see a fix coming through. I'd be more than willing to help resolve any possible issues.

@posva posva added this to Reviewed once, needs another review in 2.6.13 Mar 24, 2021
@posva posva changed the title fix(compiler): modify maybeComponent function in parser fix(warn): modify maybeComponent function in parser Mar 30, 2021
@posva posva changed the title fix(warn): modify maybeComponent function in parser fix(warns): modify maybeComponent function in parser Mar 30, 2021
@posva posva merged commit 0603ff6 into vuejs:dev Apr 7, 2021
@posva posva moved this from Reviewed once, needs another review to Done in 2.6.13 Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Scoped Slot warns when used inside of dynamic component on regular element
4 participants