Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1760: do not console.error handled exceptions #1761

Merged
merged 1 commit into from Jan 10, 2021

Conversation

marcgibbons
Copy link
Contributor

@marcgibbons marcgibbons commented Jan 6, 2021

When an exception is handled in an errorHandler function, do not re-raise it.

fix #1760

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

When an exception is handled in an `errorHandler` function, do not re-raise it.

fix vuejs#1760
@marcgibbons marcgibbons changed the title fix(error.js): do not console.error handled exceptions Fix #1760: do not console.error handled exceptions Jan 6, 2021
@lmiller1990
Copy link
Member

lmiller1990 commented Jan 9, 2021

I thought the whole idea of using createLocalVue with an error handler was that we DO want to console.error? It looks like it was added here intentionally: marcgibbons@e91effe#diff-dd59fc30dc63197a9d0939e3119aef809349799e5aa021fa73c20301d8c7bd96R8

Am I missing something?

Edit: I see we are trying to match Vue's behavior here. If that is the case, this makes sense. I am surprised it does not break the changes added in the above commit I referenced.

Copy link
Member

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay assuming the only change is matching Vue's behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exceptions handled in custom errorHandler are logged to console.error
3 participants