vue-test-utils: allow false as a component stub value
#1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyerburgh
reviewed
May 11, 2019
packages/test-utils/types/index.d.ts
Outdated
| @@ -22,7 +22,7 @@ type Slots = { | |||
| * If it is an array of string, the specified children are replaced by blank components | |||
| */ | |||
| type Stubs = { | |||
| [key: string]: Component | string | true | |||
| [key: string]: Component | string | true | false | |||
There was a problem hiding this comment.
Suggested change
| [key: string]: Component | string | true | false | |
| [key: string]: Component | string | boolean |
|
Can you also update the type file in packages/server-test-utils/types/index.d.ts? |
|
done. |
|
Hi @garyo, there's another types file for the |
Updated types/index.d.ts to allow false to be passed as a component stub value in mount or shallowMount. `false` in this case means don't use a stub for the given component. Also updated server-test-utils.
|
Sorry, I had that fix queued up, just forgot to add it! Here you go. This time for sure. :-) |
eddyerburgh
approved these changes
May 16, 2019
|
Thanks :) |
|
Thanks again! Cheers! 💚 |
|
@eddyerburgh when this fix will be available in public release? |
|
By September 15 latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated types/index.d.ts to allow false to be passed as a component stub value
in mount or shallowMount.
falsein this case means don't use a stub for thegiven component.